[FFmpeg-cvslog] wmaenc: require a large enough output buffer to prevent overwrites
Justin Ruggles
git at videolan.org
Mon Mar 5 00:28:53 CET 2012
ffmpeg | branch: master | Justin Ruggles <justin.ruggles at gmail.com> | Fri Mar 2 16:33:33 2012 -0500| [dfc4fdedf8cfc56a505579b1f2c1c5efbce4b97e] | committer: Justin Ruggles
wmaenc: require a large enough output buffer to prevent overwrites
The maximum theoretical frame size is around 17000 bytes. Although in
practice it will generally be much smaller, we require a larger buffer
just to be safe.
CC: libav-stable at libav.org
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=dfc4fdedf8cfc56a505579b1f2c1c5efbce4b97e
---
libavcodec/wmaenc.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/libavcodec/wmaenc.c b/libavcodec/wmaenc.c
index 99544c0..5135b98 100644
--- a/libavcodec/wmaenc.c
+++ b/libavcodec/wmaenc.c
@@ -365,6 +365,11 @@ static int encode_superframe(AVCodecContext *avctx,
}
}
+ if (buf_size < 2 * MAX_CODED_SUPERFRAME_SIZE) {
+ av_log(avctx, AV_LOG_ERROR, "output buffer size is too small\n");
+ return AVERROR(EINVAL);
+ }
+
#if 1
total_gain= 128;
for(i=64; i; i>>=1){
More information about the ffmpeg-cvslog
mailing list