[FFmpeg-cvslog] smacker: validate channels and sample format.

Justin Ruggles git at videolan.org
Mon Mar 19 05:30:41 CET 2012


ffmpeg | branch: release/0.8 | Justin Ruggles <justin.ruggles at gmail.com> | Wed Sep 21 11:49:33 2011 -0400| [1cc0b0863572cc4339ff38b04f48b13ec64062a2] | committer: Reinhard Tartler

smacker: validate channels and sample format.

(cherry picked from commit ff1f89de2da3472d133e2c95bf7c9ad2d88df33d)

Signed-off-by: Anton Khirnov <anton at khirnov.net>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=1cc0b0863572cc4339ff38b04f48b13ec64062a2
---

 libavcodec/smacker.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
index f3c59da..fd88fd2 100644
--- a/libavcodec/smacker.c
+++ b/libavcodec/smacker.c
@@ -606,6 +606,14 @@ static int smka_decode_frame(AVCodecContext *avctx, void *data, int *data_size,
         av_log(avctx, AV_LOG_ERROR, "Frame is too large to fit in buffer\n");
         return -1;
     }
+    if (stereo ^ (avctx->channels != 1)) {
+        av_log(avctx, AV_LOG_ERROR, "channels mismatch\n");
+        return AVERROR(EINVAL);
+    }
+    if (bits && avctx->sample_fmt == AV_SAMPLE_FMT_U8) {
+        av_log(avctx, AV_LOG_ERROR, "sample format mismatch\n");
+        return AVERROR(EINVAL);
+    }
 
     memset(vlc, 0, sizeof(VLC) * 4);
     memset(h, 0, sizeof(HuffContext) * 4);



More information about the ffmpeg-cvslog mailing list