[FFmpeg-cvslog] lavfi/aspect: check for a negative code from av_parse_ratio()

Stefano Sabatini git at videolan.org
Wed Mar 21 15:22:19 CET 2012


ffmpeg | branch: master | Stefano Sabatini <stefasab at gmail.com> | Wed Mar 21 14:39:24 2012 +0100| [e71e65ff1d7e4b70db34aa169556cf77ae25608a] | committer: Stefano Sabatini

lavfi/aspect: check for a negative code from av_parse_ratio()

Check on < 0 rather than on != 0, this is more correct as a positive
error code from av_parse_ratio() value doesn't mean an error.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=e71e65ff1d7e4b70db34aa169556cf77ae25608a
---

 libavfilter/vf_aspect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libavfilter/vf_aspect.c b/libavfilter/vf_aspect.c
index 9e3b93b..8a56116 100644
--- a/libavfilter/vf_aspect.c
+++ b/libavfilter/vf_aspect.c
@@ -37,7 +37,7 @@ static av_cold int init(AVFilterContext *ctx, const char *args, void *opaque)
     aspect->ratio = (AVRational) {0, 1};
 
     if (args) {
-        if (av_parse_ratio(&aspect->ratio, args, 100, 0, ctx) ||
+        if (av_parse_ratio(&aspect->ratio, args, 100, 0, ctx) < 0 ||
             aspect->ratio.num < 0 || aspect->ratio.den <= 0) {
             av_log(ctx, AV_LOG_ERROR,
                    "Invalid string '%s' for aspect ratio.\n", args);



More information about the ffmpeg-cvslog mailing list