[FFmpeg-cvslog] lavc/xfaceenc: prefer do{}while() over for() {} construct in xface_encode_frame() loop

Stefano Sabatini git at videolan.org
Sat Nov 3 23:38:24 CET 2012


ffmpeg | branch: master | Stefano Sabatini <stefasab at gmail.com> | Sat Nov  3 23:26:43 2012 +0100| [aa48446c9a42fc29ae46ea98717f29edc7fec27d] | committer: Stefano Sabatini

lavc/xfaceenc: prefer do{}while() over for(){} construct in xface_encode_frame() loop

Slightly simplify readability, since the initial check is unnecessary.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=aa48446c9a42fc29ae46ea98717f29edc7fec27d
---

 libavcodec/xfaceenc.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavcodec/xfaceenc.c b/libavcodec/xfaceenc.c
index db63f59..5206afd 100644
--- a/libavcodec/xfaceenc.c
+++ b/libavcodec/xfaceenc.c
@@ -167,14 +167,15 @@ static int xface_encode_frame(AVCodecContext *avctx, AVPacket *pkt,
 
     /* convert image from MONOWHITE to 1=black 0=white bitmap */
     buf = frame->data[0];
-    for (i = 0, j = 0; i < XFACE_PIXELS; ) {
+    i = j = 0;
+    do {
         for (k = 0; k < 8; k++)
             xface->bitmap[i++] = (buf[j]>>(7-k))&1;
         if (++j == XFACE_WIDTH/8) {
             buf += frame->linesize[0];
             j = 0;
         }
-    }
+    } while (i < XFACE_PIXELS);
 
     /* create a copy of bitmap */
     memcpy(bitmap_copy, xface->bitmap, XFACE_PIXELS);



More information about the ffmpeg-cvslog mailing list