[FFmpeg-cvslog] bmpdec: only initialize palette for pal8.
Anton Khirnov
git at videolan.org
Tue Oct 16 16:36:03 CEST 2012
ffmpeg | branch: release/0.10 | Anton Khirnov <anton at khirnov.net> | Sun Sep 16 08:33:09 2012 +0200| [bed5847563d1b9d3ee284f1fae442199508c7492] | committer: Anton Khirnov
bmpdec: only initialize palette for pal8.
Gray8 is not considered to be paletted, so this would cause an invalid
write.
Fixes bug 367.
CC: libav-stable at libav.org
(cherry picked from commit 8b78c2969a5b7dca939d93bf525aa2bcd737b5d9)
Signed-off-by: Anton Khirnov <anton at khirnov.net>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bed5847563d1b9d3ee284f1fae442199508c7492
---
libavcodec/bmp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/bmp.c b/libavcodec/bmp.c
index 1f725f5..974db49 100644
--- a/libavcodec/bmp.c
+++ b/libavcodec/bmp.c
@@ -227,9 +227,6 @@ static int bmp_decode_frame(AVCodecContext *avctx,
if(comp == BMP_RLE4 || comp == BMP_RLE8)
memset(p->data[0], 0, avctx->height * p->linesize[0]);
- if(depth == 4 || depth == 8)
- memset(p->data[1], 0, 1024);
-
if(height > 0){
ptr = p->data[0] + (avctx->height - 1) * p->linesize[0];
linesize = -p->linesize[0];
@@ -240,6 +237,9 @@ static int bmp_decode_frame(AVCodecContext *avctx,
if(avctx->pix_fmt == PIX_FMT_PAL8){
int colors = 1 << depth;
+
+ memset(p->data[1], 0, 1024);
+
if(ihsize >= 36){
int t;
buf = buf0 + 46;
More information about the ffmpeg-cvslog
mailing list