[FFmpeg-cvslog] network: use getservbyport() only if available

Mans Rullgard git at videolan.org
Wed Oct 24 13:21:54 CEST 2012


ffmpeg | branch: master | Mans Rullgard <mans at mansr.com> | Sun Oct 14 20:24:51 2012 +0100| [c3e73100af9b685be796bcd3e68786130d45ea24] | committer: Mans Rullgard

network: use getservbyport() only if available

The absence of this function will only give a less informative
string back from our fallback implementation of getnameinfo().

Signed-off-by: Mans Rullgard <mans at mansr.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c3e73100af9b685be796bcd3e68786130d45ea24
---

 configure                |    2 ++
 libavformat/os_support.c |    2 ++
 2 files changed, 4 insertions(+)

diff --git a/configure b/configure
index 996c716..e1524fb 100755
--- a/configure
+++ b/configure
@@ -1190,6 +1190,7 @@ HAVE_LIST="
     GetProcessTimes
     GetSystemTimeAsFileTime
     getrusage
+    getservbyport
     gettimeofday
     gnu_as
     ibm_asm
@@ -3158,6 +3159,7 @@ if enabled network; then
     check_struct "sys/types.h sys/socket.h" "struct sockaddr" sa_len
     check_type netinet/sctp.h "struct sctp_event_subscribe"
     check_func getaddrinfo $network_extralibs
+    check_func getservbyport $network_extralibs
     # Prefer arpa/inet.h over winsock2
     if check_header arpa/inet.h ; then
         check_func closesocket
diff --git a/libavformat/os_support.c b/libavformat/os_support.c
index 7618708..451801f 100644
--- a/libavformat/os_support.c
+++ b/libavformat/os_support.c
@@ -235,8 +235,10 @@ int ff_getnameinfo(const struct sockaddr *sa, int salen,
 
     if (serv && servlen > 0) {
         struct servent *ent = NULL;
+#if HAVE_GETSERVBYPORT
         if (!(flags & NI_NUMERICSERV))
             ent = getservbyport(sin->sin_port, flags & NI_DGRAM ? "udp" : "tcp");
+#endif
 
         if (ent)
             snprintf(serv, servlen, "%s", ent->s_name);



More information about the ffmpeg-cvslog mailing list