[FFmpeg-cvslog] Add CPiA video decoder

Stephan Hilb stephan at ecshi.net
Sat Sep 1 00:11:19 CEST 2012


> On Fri, Aug 31, 2012 at 06:22:27PM +0200, Reimar Döffinger wrote:
>> > +    // Get buffer filled with previous frame
>> > +    if ((ret = avctx->reget_buffer(avctx, frame)) < 0) {
>> > +        av_log(avctx, AV_LOG_ERROR, "reget_buffer() failed!\n");
>> > +        return ret;
>> > +    }
>> [...]
>> > +    if (header[28] == NOT_COMPRESSED) {
>> > +        frame->pict_type = AV_PICTURE_TYPE_I;
>> > +        frame->key_frame = 1;
>> > +    } else {
>> > +        frame->pict_type = AV_PICTURE_TYPE_P;
>> > +        frame->key_frame = 0;
>> > +    }
>> 
>> Shouldn't this be set before reget_buffer?

The builtin reget_buffer doesn't seem to use that information so it
shouldn't matter.
I could be wrong though.

>> Or rather better, reget_buffer moved after it, so as to avoid
>> getting a buffer and right after bailing out due to header errors,
>> which is at least a bit ugly.

That's right, I will address it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120901/766f9c18/attachment.asc>


More information about the ffmpeg-cvslog mailing list