[FFmpeg-cvslog] mpegvideo: fix loop condition in draw_line()

Xi Wang git at videolan.org
Tue Feb 5 16:27:12 CET 2013


ffmpeg | branch: release/1.1 | Xi Wang <xi.wang at gmail.com> | Sat Jan 19 13:21:35 2013 -0500| [8d0631c8fa890a1a01c7289c0bf8b2ff44fe5b9c] | committer: Luca Barbato

mpegvideo: fix loop condition in draw_line()

The loop condition `x = ex' is incorrect.  It should be `x <= ex'.

This bug was introduced in commit c65dfac4 "mpegvideo.c: K&R formatting
and cosmetics."

CC:libav-stable at libav.org

(cherry picked from commit 992b03183819553a73b4f870a710ef500b4eb6d0)

Signed-off-by: Luca Barbato <lu_zero at gentoo.org>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8d0631c8fa890a1a01c7289c0bf8b2ff44fe5b9c
---

 libavcodec/mpegvideo.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 0b6ddb9..10b13b5 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -1658,7 +1658,7 @@ static void draw_line(uint8_t *buf, int sx, int sy, int ex, int ey,
         buf += sx + sy * stride;
         ex  -= sx;
         f    = ((ey - sy) << 16) / ex;
-        for (x = 0; x = ex; x++) {
+        for (x = 0; x <= ex; x++) {
             y  = (x * f) >> 16;
             fr = (x * f) & 0xFFFF;
             buf[y * stride + x]       += (color * (0x10000 - fr)) >> 16;



More information about the ffmpeg-cvslog mailing list