[FFmpeg-cvslog] swr: check channel layouts before using them.

Michael Niedermayer git at videolan.org
Wed Feb 13 18:35:43 CET 2013


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Wed Feb 13 17:49:16 2013 +0100| [21cd905cd44a4bbafe8631bbaa6021d328413ce5] | committer: Michael Niedermayer

swr: check channel layouts before using them.

Fixes out of array accesses

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=21cd905cd44a4bbafe8631bbaa6021d328413ce5
---

 libswresample/swresample.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/libswresample/swresample.c b/libswresample/swresample.c
index b192bfd..9c2e3f5 100644
--- a/libswresample/swresample.c
+++ b/libswresample/swresample.c
@@ -265,6 +265,16 @@ av_cold int swr_init(struct SwrContext *s){
         return AVERROR(EINVAL);
     }
 
+    if(av_get_channel_layout_nb_channels(s-> in_ch_layout) > SWR_CH_MAX) {
+        av_log(s, AV_LOG_WARNING, "Input channel layout 0x%"PRIx64" is invalid or unsupported.\n", s-> in_ch_layout);
+        s->in_ch_layout = 0;
+    }
+
+    if(av_get_channel_layout_nb_channels(s->out_ch_layout) > SWR_CH_MAX) {
+        av_log(s, AV_LOG_WARNING, "Output channel layout 0x%"PRIx64" is invalid or unsupported.\n", s->out_ch_layout);
+        s->out_ch_layout = 0;
+    }
+
     switch(s->engine){
 #if CONFIG_LIBSOXR
         extern struct Resampler const soxr_resampler;



More information about the ffmpeg-cvslog mailing list