[FFmpeg-cvslog] flicvideo: avoid an infinite loop in byte run compression

Anton Khirnov git at videolan.org
Sun Feb 24 13:19:58 CET 2013


ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Thu Feb 14 12:40:36 2013 +0100| [ddfe1246d98f70cdce368a2176196ba26ed7bf2d] | committer: Anton Khirnov

flicvideo: avoid an infinite loop in byte run compression

When byte_run is 0, pixel_countdown is not touched and the loop will run
forever.

CC:libav-stable at libav.org

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ddfe1246d98f70cdce368a2176196ba26ed7bf2d
---

 libavcodec/flicvideo.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavcodec/flicvideo.c b/libavcodec/flicvideo.c
index f0b5d50..08c3ef3 100644
--- a/libavcodec/flicvideo.c
+++ b/libavcodec/flicvideo.c
@@ -348,6 +348,11 @@ static int flic_decode_frame_8BPP(AVCodecContext *avctx,
                 pixel_countdown = s->avctx->width;
                 while (pixel_countdown > 0) {
                     byte_run = sign_extend(bytestream2_get_byte(&g2), 8);
+                    if (!byte_run) {
+                        av_log(avctx, AV_LOG_ERROR, "Invalid byte run value.\n");
+                        return AVERROR_INVALIDDATA;
+                    }
+
                     if (byte_run > 0) {
                         palette_idx1 = bytestream2_get_byte(&g2);
                         CHECK_PIXEL_PTR(byte_run);



More information about the ffmpeg-cvslog mailing list