[FFmpeg-cvslog] xmv: do not leak memory in the error paths in xmv_read_header()

Anton Khirnov git at videolan.org
Mon Jul 29 02:44:26 CEST 2013


ffmpeg | branch: release/0.10 | Anton Khirnov <anton at khirnov.net> | Thu Mar 28 10:34:47 2013 +0100| [c65fb5b41b8e7a11a8ef472eba88c9ff08ce097e] | committer: Reinhard Tartler

xmv: do not leak memory in the error paths in xmv_read_header()

CC: libav-stable at libav.org
(cherry picked from commit f8080bd13b5f7fc48204b17fa59a5ce9feb15f07)

Signed-off-by: Reinhard Tartler <siretart at tauware.de>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c65fb5b41b8e7a11a8ef472eba88c9ff08ce097e
---

 libavformat/xmv.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/libavformat/xmv.c b/libavformat/xmv.c
index bc4b239..ee4aec3 100644
--- a/libavformat/xmv.c
+++ b/libavformat/xmv.c
@@ -178,8 +178,10 @@ static int xmv_read_header(AVFormatContext *s,
         return AVERROR(ENOMEM);
 
     xmv->audio = av_malloc(xmv->audio_track_count * sizeof(XMVAudioPacket));
-    if (!xmv->audio)
-        return AVERROR(ENOMEM);
+    if (!xmv->audio) {
+        ret = AVERROR(ENOMEM);
+        goto fail;
+    }
 
     for (audio_track = 0; audio_track < xmv->audio_track_count; audio_track++) {
         XMVAudioTrack  *track  = &xmv->audio_tracks[audio_track];
@@ -213,8 +215,10 @@ static int xmv_read_header(AVFormatContext *s,
                                       "(0x%04X)\n", track->flags);
 
         ast = avformat_new_stream(s, NULL);
-        if (!ast)
-            return AVERROR(ENOMEM);
+        if (!ast) {
+            ret = AVERROR(ENOMEM);
+            goto fail;
+        }
 
         ast->codec->codec_type            = AVMEDIA_TYPE_AUDIO;
         ast->codec->codec_id              = track->codec_id;



More information about the ffmpeg-cvslog mailing list