[FFmpeg-cvslog] configure: Don't explicitly disable PIC for windows targets

Martin Storsjö git at videolan.org
Tue Jun 11 08:53:19 CEST 2013


ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Tue May 28 15:10:37 2013 +0300| [3fd0d166aa240ef547482d1af397c4a653031c2d] | committer: Martin Storsjö

configure: Don't explicitly disable PIC for windows targets

This reverts e08c946c6 and 05165c2f7a. The actual intention of
e08c946c6 was to fix shared library builds for arm/win32, which
can also be accomplished in other ways.

Disabling pic on those platforms broke inline assembly on cygwin/64
(since some inline assembly requires knowing whether we are building
as PIC or not), and might also break inline assembly on other
compilers on windows.

As a side-effect, this unfortunately brings back all the warnings
about PIC not having any effect on that platform.

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3fd0d166aa240ef547482d1af397c4a653031c2d
---

 configure |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/configure b/configure
index 9644f03..c558aeb 100755
--- a/configure
+++ b/configure
@@ -3124,7 +3124,6 @@ case $target_os in
         dlltool="${cross_prefix}dlltool"
         ranlib=:
         enable dos_paths
-        disable pic
         ;;
     win32|win64)
         if enabled shared; then
@@ -3149,7 +3148,6 @@ case $target_os in
         objformat="win32"
         ranlib=:
         enable dos_paths
-        disable pic
         ;;
     cygwin*)
         target_os=cygwin
@@ -3164,7 +3162,6 @@ case $target_os in
         SHFLAGS='-shared -Wl,--out-implib,$(SUBDIR)lib$(FULLNAME).dll.a'
         objformat="win32"
         enable dos_paths
-        disable pic
         ;;
     *-dos|freedos|opendos)
         network_extralibs="-lsocket"



More information about the ffmpeg-cvslog mailing list