[FFmpeg-cvslog] avpacket: do not copy data when buf ref is available.
Clément Bœsch
git at videolan.org
Wed Mar 13 01:44:06 CET 2013
ffmpeg | branch: master | Clément Bœsch <ubitux at gmail.com> | Tue Mar 12 08:13:21 2013 +0100| [02a6b06d9ea0009f058b0f43c98f640f63f1359a] | committer: Clément Bœsch
avpacket: do not copy data when buf ref is available.
This at least fixes issues with lavf/subtitles. The behaviour of
av_dup_packet() is unchanged, only av_copy_packet() is affected.
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=02a6b06d9ea0009f058b0f43c98f640f63f1359a
---
libavcodec/avpacket.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
index 16496e2..651036e 100644
--- a/libavcodec/avpacket.c
+++ b/libavcodec/avpacket.c
@@ -184,7 +184,15 @@ static int copy_packet_data(AVPacket *pkt, AVPacket *src)
{
pkt->data = NULL;
pkt->side_data = NULL;
- DUP_DATA(pkt->data, src->data, pkt->size, 1, ALLOC_BUF);
+ if (pkt->buf) {
+ AVBufferRef *ref = av_buffer_ref(src->buf);
+ if (!ref)
+ return AVERROR(ENOMEM);
+ pkt->buf = ref;
+ pkt->data = ref->data;
+ } else {
+ DUP_DATA(pkt->data, src->data, pkt->size, 1, ALLOC_BUF);
+ }
#if FF_API_DESTRUCT_PACKET
pkt->destruct = dummy_destruct_packet;
#endif
@@ -228,7 +236,6 @@ int av_dup_packet(AVPacket *pkt)
int av_copy_packet(AVPacket *dst, AVPacket *src)
{
*dst = *src;
- dst->buf = av_buffer_ref(src->buf);
return copy_packet_data(dst, src);
}
More information about the ffmpeg-cvslog
mailing list