[FFmpeg-cvslog] png: use av_mallocz_array() for the zlib zalloc function

Justin Ruggles git at videolan.org
Thu Mar 14 04:47:34 CET 2013


ffmpeg | branch: release/1.1 | Justin Ruggles <justin.ruggles at gmail.com> | Wed Jan 16 18:10:57 2013 -0500| [905f5c8a1e94d224245480298b1854e103d71141] | committer: Reinhard Tartler

png: use av_mallocz_array() for the zlib zalloc function

Fixes valgrind uninitialized memory errors when decoding png.

CC:libav-stable at libav.org
(cherry picked from commit 486f0b0cfc800cd38ec06635630539431d296774)

Signed-off-by: Reinhard Tartler <siretart at tauware.de>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=905f5c8a1e94d224245480298b1854e103d71141
---

 libavcodec/png.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libavcodec/png.c b/libavcodec/png.c
index 70a080e..65d6964 100644
--- a/libavcodec/png.c
+++ b/libavcodec/png.c
@@ -47,9 +47,7 @@ const uint8_t ff_png_pass_mask[NB_PASSES] = {
 
 void *ff_png_zalloc(void *opaque, unsigned int items, unsigned int size)
 {
-    if(items >= UINT_MAX / size)
-        return NULL;
-    return av_malloc(items * size);
+    return av_mallocz_array(items, size);
 }
 
 void ff_png_zfree(void *opaque, void *ptr)



More information about the ffmpeg-cvslog mailing list