[FFmpeg-cvslog] avcodec/gifdec: Add av_log() to workaround gcc 4.2 miscompiling the code

Michael Niedermayer git at videolan.org
Mon Mar 25 13:52:44 CET 2013


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Mon Mar 25 13:32:45 2013 +0100| [afdfff485b6527fe439351ce40fa7d3f97661dc4] | committer: Michael Niedermayer

avcodec/gifdec: Add av_log() to workaround gcc 4.2 miscompiling the code

It appears gcc forgets to increment the byte stream pointer at -O3
I was not able to spot a reason/excuse for it to do that. It
also disappears if the function isnt inlined.

This should fix the gif fate failures on open & free bsd

See: [FFmpeg-devel] [PATCH] gifdec: workaround old gcc 4.2 mis-compiling code

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=afdfff485b6527fe439351ce40fa7d3f97661dc4
---

 libavcodec/gifdec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/gifdec.c b/libavcodec/gifdec.c
index 27364c9..997bd42 100644
--- a/libavcodec/gifdec.c
+++ b/libavcodec/gifdec.c
@@ -406,7 +406,7 @@ static int gif_parse_next_image(GifState *s, AVFrame *frame)
         int code = bytestream2_get_byte(&s->gb);
         int ret;
 
-        av_dlog(s->avctx, "code=%02x '%c'\n", code, code);
+        av_log(s->avctx, AV_LOG_DEBUG, "code=%02x '%c'\n", code, code);
 
         switch (code) {
         case GIF_IMAGE_SEPARATOR:



More information about the ffmpeg-cvslog mailing list