[FFmpeg-cvslog] avformat/utils: Check av_packet_new_side_data() return before using it

Michael Niedermayer git at videolan.org
Sun Oct 20 18:46:06 CEST 2013


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Sun Oct 20 18:33:53 2013 +0200| [88d4ff4b5f4c28fe38fa257b1d19b8fede4c35cc] | committer: Michael Niedermayer

avformat/utils: Check av_packet_new_side_data() return before using it

Fixes null pointer dereference
Fixes CID1108592
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=88d4ff4b5f4c28fe38fa257b1d19b8fede4c35cc
---

 libavformat/utils.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavformat/utils.c b/libavformat/utils.c
index 50f7d87..1c036aa 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -1504,8 +1504,10 @@ return_packet:
     st = s->streams[pkt->stream_index];
     if (st->skip_samples) {
         uint8_t *p = av_packet_new_side_data(pkt, AV_PKT_DATA_SKIP_SAMPLES, 10);
-        AV_WL32(p, st->skip_samples);
-        av_log(s, AV_LOG_DEBUG, "demuxer injecting skip %d\n", st->skip_samples);
+        if (p) {
+            AV_WL32(p, st->skip_samples);
+            av_log(s, AV_LOG_DEBUG, "demuxer injecting skip %d\n", st->skip_samples);
+        }
         st->skip_samples = 0;
     }
 



More information about the ffmpeg-cvslog mailing list