[FFmpeg-cvslog] twinvqdec: Check the ibps parameter separately

Martin Storsjö git at videolan.org
Wed Sep 18 12:47:51 CEST 2013


ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Tue Sep 17 19:33:48 2013 +0300| [c77d409bf95954aceb762dd800d1ee2868c4b0d4] | committer: Martin Storsjö

twinvqdec: Check the ibps parameter separately

This is required, since invalid parameters actually could
pass the switch check below.

Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable at libav.org
Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c77d409bf95954aceb762dd800d1ee2868c4b0d4
---

 libavcodec/twinvqdec.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/twinvqdec.c b/libavcodec/twinvqdec.c
index a88b6ff..580c1f2 100644
--- a/libavcodec/twinvqdec.c
+++ b/libavcodec/twinvqdec.c
@@ -356,6 +356,10 @@ static av_cold int twinvq_decode_init(AVCodecContext *avctx)
                                                  : AV_CH_LAYOUT_STEREO;
 
     ibps = avctx->bit_rate / (1000 * avctx->channels);
+    if (ibps < 8 || ibps > 48) {
+        av_log(avctx, AV_LOG_ERROR, "Bad bitrate per channel value %d\n", ibps);
+        return AVERROR_INVALIDDATA;
+    }
 
     switch ((isampf << 8) + ibps) {
     case (8 << 8) + 8:



More information about the ffmpeg-cvslog mailing list