[FFmpeg-cvslog] mpegvideo: Avoid 32-bit wrapping of linesize?multiplications

Michael Niedermayer michaelni at gmx.at
Fri Sep 27 03:21:05 CEST 2013


On Thu, Sep 26, 2013 at 10:22:49AM +0000, Joakim Plate wrote:
> Martin Storsjö <git <at> videolan.org> writes:
> 
> > 
> > ffmpeg | branch: release/0.10 | Martin Storsjö <martin <at> martin.st> | Wed 
> Sep  4 01:36:51 2013 +0300|
> > [5473d23ece9e42a8003fc880027fe242604ce367] | committer: Sean McGovern
> > 
> > mpegvideo: Avoid 32-bit wrapping of linesize multiplications
> > 
> >      uint8_t *ptr_y, *ptr_cb, *ptr_cr;
> >      int dxy, uvdxy, mx, my, src_x, src_y,
> > -        uvsrc_x, uvsrc_y, v_edge_pos, uvlinesize, linesize;
> > +        uvsrc_x, uvsrc_y, v_edge_pos;
> > +    ptrdiff_t uvlinesize, linesize;
> > 
> 
> 
> Is there a specific reason you are only correcting this for 64bit machines? 
> ptrdiff_t is 32 on 32bit machines (ie no different from int)

Fixed in f66ecdb1b4de01e4afdc1e2c8640ce57ddec15ff.
AFAIK, ronald is working on a complete and nicer fix, though iam, not
sure if that would get backported by anyone ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20130927/ddddae9b/attachment.asc>


More information about the ffmpeg-cvslog mailing list