[FFmpeg-cvslog] resample: remove an unneeded context variable

Anton Khirnov git at videolan.org
Thu Apr 17 21:37:51 CEST 2014


ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Sat Feb 22 20:27:44 2014 +0100| [21d8f4da91673051ad7055cf63d989488a56368e] | committer: Anton Khirnov

resample: remove an unneeded context variable

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=21d8f4da91673051ad7055cf63d989488a56368e
---

 libavresample/resample.c |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/libavresample/resample.c b/libavresample/resample.c
index 03362c8..5fd6b90 100644
--- a/libavresample/resample.c
+++ b/libavresample/resample.c
@@ -42,7 +42,6 @@ struct ResampleContext {
     int linear;
     enum AVResampleFilterType filter_type;
     int kaiser_beta;
-    double factor;
     void (*set_filter)(void *filter, double *tab, int phase, int tap_count);
     void (*resample_one)(struct ResampleContext *c, void *dst0,
                          int dst_index, const void *src0,
@@ -94,10 +93,10 @@ static double bessel(double x)
 }
 
 /* Build a polyphase filterbank. */
-static int build_filter(ResampleContext *c)
+static int build_filter(ResampleContext *c, double factor)
 {
     int ph, i;
-    double x, y, w, factor;
+    double x, y, w;
     double *tab;
     int tap_count    = c->filter_length;
     int phase_count  = 1 << c->phase_shift;
@@ -107,9 +106,6 @@ static int build_filter(ResampleContext *c)
     if (!tab)
         return AVERROR(ENOMEM);
 
-    /* if upsampling, only need to interpolate, no filter */
-    factor = FFMIN(c->factor, 1.0);
-
     for (ph = 0; ph < phase_count; ph++) {
         double norm = 0;
         for (i = 0; i < tap_count; i++) {
@@ -176,7 +172,6 @@ ResampleContext *ff_audio_resample_init(AVAudioResampleContext *avr)
     c->phase_shift   = avr->phase_shift;
     c->phase_mask    = phase_count - 1;
     c->linear        = avr->linear_interp;
-    c->factor        = factor;
     c->filter_length = FFMAX((int)ceil(avr->filter_size / factor), 1);
     c->filter_type   = avr->filter_type;
     c->kaiser_beta   = avr->kaiser_beta;
@@ -209,7 +204,7 @@ ResampleContext *ff_audio_resample_init(AVAudioResampleContext *avr)
     if (!c->filter_bank)
         goto error;
 
-    if (build_filter(c) < 0)
+    if (build_filter(c, factor) < 0)
         goto error;
 
     memcpy(&c->filter_bank[(c->filter_length * phase_count + 1) * felem_size],



More information about the ffmpeg-cvslog mailing list