[FFmpeg-cvslog] bfi: Add some very basic sanity checks for input packet sizes

Martin Storsjö git at videolan.org
Thu Jan 16 22:36:38 CET 2014


ffmpeg | branch: release/0.10 | Martin Storsjö <martin at martin.st> | Sat Sep 28 23:46:04 2013 +0300| [213b8aa0a90585f13aebb7fba39cbd3e367e98a6] | committer: Luca Barbato

bfi: Add some very basic sanity checks for input packet sizes

CC: libav-stable at libav.org
Signed-off-by: Martin Storsjö <martin at martin.st>
(cherry picked from commit 640a2427aafa774b83316b7a8c5c2bdc28bfd269)
Signed-off-by: Luca Barbato <lu_zero at gentoo.org>
(cherry picked from commit 10f384e4f5d0ee692cacaf90d629d8bc2178b092)

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=213b8aa0a90585f13aebb7fba39cbd3e367e98a6
---

 libavformat/bfi.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavformat/bfi.c b/libavformat/bfi.c
index c0b5681..326c1f3 100644
--- a/libavformat/bfi.c
+++ b/libavformat/bfi.c
@@ -130,6 +130,10 @@ static int bfi_read_packet(AVFormatContext * s, AVPacket * pkt)
         video_offset    = avio_rl32(pb);
         audio_size      = video_offset - audio_offset;
         bfi->video_size = chunk_size - video_offset;
+        if (audio_size < 0 || bfi->video_size < 0) {
+            av_log(s, AV_LOG_ERROR, "Invalid audio/video offsets or chunk size\n");
+            return AVERROR_INVALIDDATA;
+        }
 
         //Tossing an audio packet at the audio decoder.
         ret = av_get_packet(pb, pkt, audio_size);



More information about the ffmpeg-cvslog mailing list