[FFmpeg-cvslog] lavf/id3v2enc: update comment about minimum padding

James Darnley git at videolan.org
Fri Jan 24 23:19:11 CET 2014


ffmpeg | branch: master | James Darnley <james.darnley at gmail.com> | Thu Jan  2 20:34:35 2014 +0100| [67270ccd3af97321958396d237f5a442132a9296] | committer: Michael Niedermayer

lavf/id3v2enc: update comment about minimum padding

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=67270ccd3af97321958396d237f5a442132a9296
---

 libavformat/id3v2enc.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/libavformat/id3v2enc.c b/libavformat/id3v2enc.c
index 8bb5392..4d555b3 100644
--- a/libavformat/id3v2enc.c
+++ b/libavformat/id3v2enc.c
@@ -333,11 +333,10 @@ void ff_id3v2_finish(ID3v2EncContext *id3, AVIOContext *pb,
     /* The ID3v2.3 specification states that 28 bits are used to represent the
      * size of the whole tag.  Therefore the current size of the tag needs to be
      * subtracted from the upper limit of 2^28-1 to clip the value correctly. */
+    /* The minimum of 10 is an arbitrary amount of padding at the end of the tag
+     * to fix cover art display with some software such as iTunes, Traktor,
+     * Serato, Torq. */
     padding_bytes = av_clip(padding_bytes, 10, 268435455 - id3->len);
-
-    /* adding an arbitrary amount of padding bytes at the end of the
-     * ID3 metadata fixes cover art display for some software (iTunes,
-     * Traktor, Serato, Torq) */
     ffio_fill(pb, 0, padding_bytes);
     id3->len += padding_bytes;
 



More information about the ffmpeg-cvslog mailing list