[FFmpeg-cvslog] caf: Use correct printf conversion specifiers for POSIX int types

[Reimar Döffinger]

On Tue, Jul 29, 2014 at 10:12:35AM +0200, Clément Bœsch wrote:
> On Tue, Jul 29, 2014 at 01:51:08AM +0200, Diego Biurrun wrote:
> > ffmpeg | branch: master | Diego Biurrun <diego at biurrun.de> | Mon Jul 28 09:21:57 2014 -0700| [942269fd00cb48328e4cffb6e21a0b691ce9f6bc] | committer: Diego Biurrun
> > 
> > caf: Use correct printf conversion specifiers for POSIX int types
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=942269fd00cb48328e4cffb6e21a0b691ce9f6bc
> > ---
> > 
> >  libavformat/cafdec.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
> > index 7966225..6574623 100644
> > --- a/libavformat/cafdec.c
> > +++ b/libavformat/cafdec.c
> > @@ -292,7 +292,7 @@ static int read_header(AVFormatContext *s)
> >          default:
> >  #define _(x) ((x) >= ' ' ? (x) : ' ')
> >              av_log(s, AV_LOG_WARNING,
> > -                   "skipping CAF chunk: %08"PRIX32" (%"PRIu8"%"PRIu8"%"PRIu8"%"PRIu8")\n",
> > +                   "skipping CAF chunk: %08"PRIX32" (%"PRIu32"%"PRIu32"%"PRIu32"%"PRIu32")\n",
> >                  tag, _(tag>>24), _((tag>>16)&0xFF), _((tag>>8)&0xFF), _(tag&0xFF));
> 
> Thanks for not merging this. The initial (not merged) change was already
> non-sense but this is now starting to be completely braindead. Or maybe
> I'm missing something?

No, you aren't. The _ macro should probably be changed to include a "char" cast
to avoid the warnings/type mismatches instead.