[FFmpeg-cvslog] lavf: Use wchar functions for filenames on windows for mkdir/rmdir/rename/ unlink

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Nov 25 09:07:37 CET 2014


On 25.11.2014, at 04:04, git at videolan.org (Martin Storsjö) wrote:
> ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Mon Nov 17 23:08:15 2014 +0200| [960aff379da46dcaff61504a57714d4d4e758e41] | committer: Martin Storsjö
> 
> lavf: Use wchar functions for filenames on windows for mkdir/rmdir/rename/unlink

I don't think we should fall back to the CP_ACP case if the conversion failed with ENOMEM.
Also, don't we already have a utf8 to multibyte conversion we used for e.g. open() somewhere we should try to reuse?

> +    *filename_w = av_mallocz(sizeof(wchar_t) * num_chars);

Nit: don't we usually prefer sizeof(**filename) over sizeof(type)?


More information about the ffmpeg-cvslog mailing list