[FFmpeg-cvslog] avcodec/x86/vp9lpf: Always include x86util.asm

Clément Bœsch u at pkh.me
Thu Sep 18 07:55:33 CEST 2014

On Thu, Sep 18, 2014 at 07:53:03AM +0200, Reimar Döffinger wrote:
> On 18.09.2014, at 01:40, git at videolan.org (Michael Niedermayer) wrote:
> > ffmpeg | branch: release/2.4 | Michael Niedermayer <michaelni at gmx.at> | Wed Sep 17 23:36:53 2014 +0200| [d694ab846cf194862d5a0aa70217849b248c26ab] | committer: Michael Niedermayer
> > 
> > avcodec/x86/vp9lpf: Always include x86util.asm
> > 
> > Fixes executable stack
> What does "fixes" mean?

According to

"Executable stack is usually an error as it is only needed if the code
contains GCC trampolines or similar constructs which uses code on the
stack. One possible source for false positives are object files built from
assembler files which don't define a proper .note.GNU-stack section."

I'd say this is exactly what happened here

> Are we not using -Wl,noexecstack?
> Leaving the compiler a choice in it does seem risky to me.

Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20140918/474b64fd/attachment.asc>

More information about the ffmpeg-cvslog mailing list