[FFmpeg-cvslog] configure: make assignment of variable to '=' explicit

Ganesh Ajjanagadde git at videolan.org
Tue Sep 15 23:59:15 CEST 2015


ffmpeg | branch: master | Ganesh Ajjanagadde <gajjanagadde at gmail.com> | Sun Sep 13 02:26:04 2015 -0400| [6d1801b5aaf9b384e13adffff4ab5886dae65693] | committer: Timothy Gu

configure: make assignment of variable to '=' explicit

op== is confusing, as it may easily be mistook for an equality check,
while in reality it is doing an assigment to '='.
This patch has the additional benefit of cleaning up 2 warnings from shellcheck.net.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6d1801b5aaf9b384e13adffff4ab5886dae65693
---

 configure |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index da18e70..2fb625b 100755
--- a/configure
+++ b/configure
@@ -622,12 +622,12 @@ enable_deep_weak(){
 }
 
 enabled(){
-    test "${1#!}" = "$1" && op== || op=!=
+    test "${1#!}" = "$1" && op='=' || op=!=
     eval test "x\$${1#!}" $op "xyes"
 }
 
 disabled(){
-    test "${1#!}" = "$1" && op== || op=!=
+    test "${1#!}" = "$1" && op='=' || op=!=
     eval test "x\$${1#!}" $op "xno"
 }
 



More information about the ffmpeg-cvslog mailing list