[FFmpeg-cvslog] avcodec/bmp: Fix runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself

Michael Niedermayer git at videolan.org
Tue Feb 21 20:06:23 EET 2017


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Tue Feb 21 16:22:47 2017 +0100| [0c42d0add37c8a41bc75179efe0571305d9165d1] | committer: Michael Niedermayer

avcodec/bmp: Fix runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself

There is code checking height and width later, leaving an invalid value invalid
is thus fine.

Fixes: 635/clusterfuzz-testcase-6225161437052928
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=0c42d0add37c8a41bc75179efe0571305d9165d1
---

 libavcodec/bmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/bmp.c b/libavcodec/bmp.c
index fa1d6a5..d462385 100644
--- a/libavcodec/bmp.c
+++ b/libavcodec/bmp.c
@@ -133,7 +133,7 @@ static int bmp_decode_frame(AVCodecContext *avctx,
     }
 
     avctx->width  = width;
-    avctx->height = height > 0 ? height : -height;
+    avctx->height = height > 0 ? height : -(unsigned)height;
 
     avctx->pix_fmt = AV_PIX_FMT_NONE;
 



More information about the ffmpeg-cvslog mailing list