[FFmpeg-cvslog] configure: Add quotes around a variable which might be empty

Martin Storsjö git at videolan.org
Fri May 19 13:01:49 EEST 2017


ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Wed Jan 25 15:11:23 2017 +0200| [f96d07f4ec4193fb5293d7ac8f1324aac3c3ea07] | committer: Martin Storsjö

configure: Add quotes around a variable which might be empty

If we only have a target compiler but no host compiler, the $type
variable will be empty once.

(Currently we fail to do a cross build if no host compiler is available
due to using the host compiler for processing option lists though.
But despite that, this comparison in configure needs quotes.)

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f96d07f4ec4193fb5293d7ac8f1324aac3c3ea07
---

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index f1867532a0..7570c0a388 100755
--- a/configure
+++ b/configure
@@ -5033,7 +5033,7 @@ fi
 for pfx in "" host_; do
     varname=${pfx%_}cc_type
     eval "type=\$$varname"
-    if [ $type = "msvc" ]; then
+    if [ "$type" = "msvc" ]; then
         check_${pfx}cc <<EOF || add_${pfx}cflags -Dinline=__inline
 static inline int foo(int a) { return a; }
 EOF



More information about the ffmpeg-cvslog mailing list