[FFmpeg-cvslog] configure: Don't add -fPIC to asflags when targeting windows

Martin Storsjö git at videolan.org
Sat Nov 11 21:57:50 EET 2017


ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Thu Oct 12 11:04:53 2017 +0300| [0ca66409911e9fba940424be8bdfa54e056b0a4b] | committer: Martin Storsjö

configure: Don't add -fPIC to asflags when targeting windows

On X86 windows, asflags weren't actually ever used for anything,
since assembling used x86asflags instead, and that flags list
had -DPIC already.

This fixes building shared libraries with clang for arm/aarch64
windows. (This wasn't an issue when in msvc mode before, since
we don't try to enable pic at all there, since the msvc armasm
assembler fails on our pic constructs there.)

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=0ca66409911e9fba940424be8bdfa54e056b0a4b
---

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 4661d9942f..96b99b0501 100755
--- a/configure
+++ b/configure
@@ -4219,9 +4219,9 @@ enable_weak_pic() {
         ;;
     *)
         add_cflags -fPIC
+        add_asflags -fPIC
         ;;
     esac
-    add_asflags  -fPIC
 }
 
 enabled pic && enable_weak_pic



More information about the ffmpeg-cvslog mailing list