[FFmpeg-cvslog] avformat/movenc: add reason for minf->hdlr in MOV only

Gyan Doshi git at videolan.org
Sat Jul 14 09:34:52 EEST 2018


ffmpeg | branch: master | Gyan Doshi <ffmpeg at gyani.pro> | Sat Jul 14 12:19:58 2018 +0530| [28ed68fa31776b43ce718a78c4d3078fd60cd7c9] | committer: Gyan Doshi

avformat/movenc: add reason for minf->hdlr in MOV only

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=28ed68fa31776b43ce718a78c4d3078fd60cd7c9
---

 libavformat/movenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 804deef10a..54a248cf8e 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -2674,7 +2674,7 @@ static int mov_write_minf_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContext
     } else if (track->tag == MKTAG('g','p','m','d')) {
         mov_write_gmhd_tag(pb, track);
     }
-    if (track->mode == MODE_MOV) /* FIXME: Why do it for MODE_MOV only ? */
+    if (track->mode == MODE_MOV) /* ISO 14496-12 8.4.3.1 specifies hdlr only within mdia or meta boxes */
         mov_write_hdlr_tag(s, pb, NULL);
     mov_write_dinf_tag(pb);
     if ((ret = mov_write_stbl_tag(s, pb, mov, track)) < 0)



More information about the ffmpeg-cvslog mailing list