[FFmpeg-cvslog] avfilter/vf_convolution: Fix build failures

Andreas Rheinhardt git at videolan.org
Wed Aug 14 09:58:41 EEST 2019

ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Mon Aug 12 03:14:55 2019 +0200| [8fcc5d963ebc5a9b8ee21fc79e5f3526f62a605d] | committer: Ruiling Song

avfilter/vf_convolution: Fix build failures

98e419cb added SIMD for the convolution filter for x64 systems. As
usual, it used a check of the form
if (ARCH_X86_64)
and thereby relied on the compiler eliminating this pseudo-runtime check
at compiletime for non x64 systems (for which ff_convolution_init_x86
isn't defined) to compile. But vf_convolution.c contains more than one
filter and if the convolution filter is disabled, but one of the other
filters (prewitt, sobel, roberts) is enabled, the build will fail on x64,
because ff_convolution_init_x86 isn't defined in this case.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8fcc5d963ebc5a9b8ee21fc79e5f3526f62a605d

 libavfilter/vf_convolution.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c
index e3bf1df79f..f29df38a20 100644
--- a/libavfilter/vf_convolution.c
+++ b/libavfilter/vf_convolution.c
@@ -588,8 +588,9 @@ static int config_input(AVFilterLink *inlink)
                     s->filter[p] = filter16_7x7;
-        if (ARCH_X86_64)
-            ff_convolution_init_x86(s);
+        ff_convolution_init_x86(s);
     } else if (!strcmp(ctx->filter->name, "prewitt")) {
         if (s->depth > 8)
             for (p = 0; p < s->nb_planes; p++)

More information about the ffmpeg-cvslog mailing list