[FFmpeg-cvslog] FATE/dnn: let fate/dnn tests depend on ffmpeg static libraries

Guo, Yejun git at videolan.org
Mon Aug 19 17:38:01 EEST 2019

ffmpeg | branch: master | Guo, Yejun <yejun.guo at intel.com> | Wed Aug  7 10:44:27 2019 +0800| [d0fa1a58da71492f665759e73c47daf04a9b658c] | committer: Pedro Arthur

FATE/dnn: let fate/dnn tests depend on ffmpeg static libraries

DNN (deep neural network) is a sub module of libavfilter, and FATE/dnn
is unit test for the DNN module, one unit test for one dnn layer.
The unit tests are not based on the APIs exported by libavfilter,
they just directly call into the functions within DNN submodule.

There is an issue when run the following command:
build$ ../ffmpeg/configure --disable-static --enable-shared
make fate-dnn-layer-pad

And part of error message:
tests/dnn/dnn-layer-pad-test.o: In function `test_with_mode_symmetric':
/work/media/ffmpeg/build/src/tests/dnn/dnn-layer-pad-test.c:73: undefined reference to `dnn_execute_layer_pad'

The root cause is that function dnn_execute_layer_pad is a LOCAL symbol
in libavfilter.so, and so the linker could not find it when build dnn-layer-pad-test.
To check it, just run: readelf -s libavfilter/libavfilter.so | grep dnn

So, add dependency in fate/dnn Makefile with ffmpeg static libraries.
This is the same method used in fate/checkasm

Signed-off-by: Guo, Yejun <yejun.guo at intel.com>
Signed-off-by: Pedro Arthur <bygrandao at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=d0fa1a58da71492f665759e73c47daf04a9b658c

 tests/dnn/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/dnn/Makefile b/tests/dnn/Makefile
index b2e668003f..0e050ea218 100644
--- a/tests/dnn/Makefile
+++ b/tests/dnn/Makefile
 -include $(wildcard $(DNNTESTOBJS:.o=.d))
-	$(LD) $(LDFLAGS) $(LDEXEFLAGS) $(LD_O) $(filter %.o,$^) $(FF_EXTRALIBS) $(ELIBS)
+	$(LD) $(LDFLAGS) $(LDEXEFLAGS) $(LD_O) $(filter %.o,$^) $(FF_STATIC_DEP_LIBS) $(ELIBS)
 	$(RM) $(addprefix $(DNNTESTSDIR)/,$(CLEANSUFFIXES) *-test$(EXESUF))

More information about the ffmpeg-cvslog mailing list