[FFmpeg-cvslog] avcodec/xvididct: Fix integer overflow in MULT()
Michael Niedermayer
git at videolan.org
Tue Apr 7 20:08:57 EEST 2020
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Fri Jan 31 23:43:57 2020 +0100| [7ccb576191e91b393041b14917f1b681ec75ed3b] | committer: Michael Niedermayer
avcodec/xvididct: Fix integer overflow in MULT()
Fixes: signed integer overflow: 23170 * 95058 cannot be represented in type 'int'
Fixes: 20295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEG_fuzzer-5800212870463488
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7ccb576191e91b393041b14917f1b681ec75ed3b
---
libavcodec/xvididct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/xvididct.c b/libavcodec/xvididct.c
index d8f3dd7072..14116bd6d3 100644
--- a/libavcodec/xvididct.c
+++ b/libavcodec/xvididct.c
@@ -142,7 +142,7 @@ static int idct_row(short *in, const int *const tab, int rnd)
#define TAN3 0xAB0E
#define SQRT2 0x5A82
-#define MULT(c, x, n) (((c) * (x)) >> (n))
+#define MULT(c, x, n) ((unsigned)((int)((c) * (unsigned)(x)) >> (n)))
// 12b version => #define MULT(c,x, n) ((((c) >> 3) * (x)) >> ((n) - 3))
// 12b zero-testing version:
More information about the ffmpeg-cvslog
mailing list