[FFmpeg-cvslog] avcodec/alac: Fix integer overflow in LPC coefficient adaption
Michael Niedermayer
git at videolan.org
Fri Apr 24 02:12:59 EEST 2020
ffmpeg | branch: release/2.8 | Michael Niedermayer <michael at niedermayer.cc> | Sat Dec 7 20:42:54 2019 +0100| [aefc24beb24494b15d4b79f9f78f6013ac100db5] | committer: Michael Niedermayer
avcodec/alac: Fix integer overflow in LPC coefficient adaption
Fixes: signed integer overflow: 267693597 * 10 cannot be represented in type 'int'
Fixes: 19237/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5755407700328448
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 6a865cec5e7584ef476f394fc55c1fc91cec1a14)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=aefc24beb24494b15d4b79f9f78f6013ac100db5
---
libavcodec/alac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/alac.c b/libavcodec/alac.c
index f60fcfcd9a..a4e899b4de 100644
--- a/libavcodec/alac.c
+++ b/libavcodec/alac.c
@@ -224,7 +224,7 @@ static void lpc_prediction(int32_t *error_buffer, uint32_t *buffer_out,
sign = sign_only(val) * error_sign;
lpc_coefs[j] -= sign;
val *= (unsigned)sign;
- error_val -= (val >> lpc_quant) * (j + 1);
+ error_val -= (val >> lpc_quant) * (j + 1U);
}
}
}
More information about the ffmpeg-cvslog
mailing list