[FFmpeg-cvslog] avformat/hevc: Defer initializations in ff_isom_write_hvcc()
Andreas Rheinhardt
git at videolan.org
Thu Jul 2 04:01:02 EEST 2020
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Thu Jan 23 04:10:48 2020 +0100| [1884d887bae30d702ac4d059fe80646e8d2f294b] | committer: Andreas Rheinhardt
avformat/hevc: Defer initializations in ff_isom_write_hvcc()
Saves initialization of an HEVCDecoderConfigurationRecord when
the data is already in ISOBMFF-format or if it is plainly invalid.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=1884d887bae30d702ac4d059fe80646e8d2f294b
---
libavformat/hevc.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/libavformat/hevc.c b/libavformat/hevc.c
index f621cb2f19..94eb3a9cb1 100644
--- a/libavformat/hevc.c
+++ b/libavformat/hevc.c
@@ -1068,29 +1068,27 @@ int ff_hevc_annexb2mp4_buf(const uint8_t *buf_in, uint8_t **buf_out,
int ff_isom_write_hvcc(AVIOContext *pb, const uint8_t *data,
int size, int ps_array_completeness)
{
- int ret = 0;
- uint8_t *buf, *end, *start = NULL;
HEVCDecoderConfigurationRecord hvcc;
-
- hvcc_init(&hvcc);
+ uint8_t *buf, *end, *start;
+ int ret;
if (size < 6) {
/* We can't write a valid hvcC from the provided data */
- ret = AVERROR_INVALIDDATA;
- goto end;
+ return AVERROR_INVALIDDATA;
} else if (*data == 1) {
/* Data is already hvcC-formatted */
avio_write(pb, data, size);
- goto end;
+ return 0;
} else if (!(AV_RB24(data) == 1 || AV_RB32(data) == 1)) {
/* Not a valid Annex B start code prefix */
- ret = AVERROR_INVALIDDATA;
- goto end;
+ return AVERROR_INVALIDDATA;
}
ret = ff_avc_parse_nal_units_buf(data, &start, &size);
if (ret < 0)
- goto end;
+ return ret;
+
+ hvcc_init(&hvcc);
buf = start;
end = start + size;
More information about the ffmpeg-cvslog
mailing list