[FFmpeg-cvslog] avformat/smoothstreaming: Add deinit function
Andreas Rheinhardt
git at videolan.org
Sun Jun 28 00:29:39 EEST 2020
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Fri Dec 20 19:57:34 2019 +0100| [3129897c0504424285a984d58e64d959a78f3c2a] | committer: Andreas Rheinhardt
avformat/smoothstreaming: Add deinit function
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3129897c0504424285a984d58e64d959a78f3c2a
---
libavformat/smoothstreamingenc.c | 43 +++++++++++++++-------------------------
1 file changed, 16 insertions(+), 27 deletions(-)
diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c
index 6599687681..ba5cc27ca0 100644
--- a/libavformat/smoothstreamingenc.c
+++ b/libavformat/smoothstreamingenc.c
@@ -286,21 +286,18 @@ static int ism_write_header(AVFormatContext *s)
ff_const59 AVOutputFormat *oformat;
if (mkdir(s->url, 0777) == -1 && errno != EEXIST) {
- ret = AVERROR(errno);
av_log(s, AV_LOG_ERROR, "mkdir failed\n");
- goto fail;
+ return AVERROR(errno);
}
oformat = av_guess_format("ismv", NULL, NULL);
if (!oformat) {
- ret = AVERROR_MUXER_NOT_FOUND;
- goto fail;
+ return AVERROR_MUXER_NOT_FOUND;
}
c->streams = av_mallocz_array(s->nb_streams, sizeof(*c->streams));
if (!c->streams) {
- ret = AVERROR(ENOMEM);
- goto fail;
+ return AVERROR(ENOMEM);
}
for (i = 0; i < s->nb_streams; i++) {
@@ -318,24 +315,21 @@ static int ism_write_header(AVFormatContext *s)
}
if (mkdir(os->dirname, 0777) == -1 && errno != EEXIST) {
- ret = AVERROR(errno);
av_log(s, AV_LOG_ERROR, "mkdir failed\n");
- goto fail;
+ return AVERROR(errno);
}
os->ctx = ctx = avformat_alloc_context();
if (!ctx) {
- ret = AVERROR(ENOMEM);
- goto fail;
+ return AVERROR(ENOMEM);
}
if ((ret = ff_copy_whiteblacklists(ctx, s)) < 0)
- goto fail;
+ return ret;
ctx->oformat = oformat;
ctx->interrupt_callback = s->interrupt_callback;
if (!(st = avformat_new_stream(ctx, NULL))) {
- ret = AVERROR(ENOMEM);
- goto fail;
+ return AVERROR(ENOMEM);
}
avcodec_parameters_copy(st->codecpar, s->streams[i]->codecpar);
st->sample_aspect_ratio = s->streams[i]->sample_aspect_ratio;
@@ -343,8 +337,7 @@ static int ism_write_header(AVFormatContext *s)
ctx->pb = avio_alloc_context(os->iobuf, sizeof(os->iobuf), AVIO_FLAG_WRITE, os, NULL, ism_write, ism_seek);
if (!ctx->pb) {
- ret = AVERROR(ENOMEM);
- goto fail;
+ return AVERROR(ENOMEM);
}
av_dict_set_int(&opts, "ism_lookahead", c->lookahead_count, 0);
@@ -352,7 +345,7 @@ static int ism_write_header(AVFormatContext *s)
ret = avformat_write_header(ctx, &opts);
av_dict_free(&opts);
if (ret < 0) {
- goto fail;
+ return ret;
}
avio_flush(ctx->pb);
s->streams[i]->time_base = st->time_base;
@@ -365,8 +358,7 @@ static int ism_write_header(AVFormatContext *s)
os->fourcc = "WVC1";
} else {
av_log(s, AV_LOG_ERROR, "Unsupported video codec\n");
- ret = AVERROR(EINVAL);
- goto fail;
+ return AVERROR(EINVAL);
}
} else {
c->has_audio = 1;
@@ -379,8 +371,7 @@ static int ism_write_header(AVFormatContext *s)
os->audio_tag = 0x0162;
} else {
av_log(s, AV_LOG_ERROR, "Unsupported audio codec\n");
- ret = AVERROR(EINVAL);
- goto fail;
+ return AVERROR(EINVAL);
}
os->packet_size = st->codecpar->block_align ? st->codecpar->block_align : 4;
}
@@ -389,15 +380,13 @@ static int ism_write_header(AVFormatContext *s)
if (!c->has_video && c->min_frag_duration <= 0) {
av_log(s, AV_LOG_WARNING, "no video stream and no min frag duration set\n");
- ret = AVERROR(EINVAL);
- goto fail;
+ return AVERROR(EINVAL);
}
ret = write_manifest(s, 0);
+ if (ret < 0)
+ return ret;
-fail:
- if (ret)
- ism_free(s);
- return ret;
+ return 0;
}
static int parse_fragment(AVFormatContext *s, const char *filename, int64_t *start_ts, int64_t *duration, int64_t *moof_size, int64_t size)
@@ -626,7 +615,6 @@ static int ism_write_trailer(AVFormatContext *s)
rmdir(s->url);
}
- ism_free(s);
return 0;
}
@@ -659,5 +647,6 @@ AVOutputFormat ff_smoothstreaming_muxer = {
.write_header = ism_write_header,
.write_packet = ism_write_packet,
.write_trailer = ism_write_trailer,
+ .deinit = ism_free,
.priv_class = &ism_class,
};
More information about the ffmpeg-cvslog
mailing list