[FFmpeg-cvslog] avdevice/lavfi: Don't unnecessarily write '\0' to AVBPrint

Andreas Rheinhardt git at videolan.org
Fri Dec 3 18:23:13 EET 2021


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Thu Dec  2 16:51:17 2021 +0100| [84f037edc2065db348879a9312720a93e54a4942] | committer: Andreas Rheinhardt

avdevice/lavfi: Don't unnecessarily write '\0' to AVBPrint

An AVBPrint's internal string is always already zero-terminated;
writing another '\0' is unnecessary as long as one treats
the string only as a C-string.

Reviewed-by: Nicolas George <george at nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=84f037edc2065db348879a9312720a93e54a4942
---

 libavdevice/lavfi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
index d9083ad984..2659c8508a 100644
--- a/libavdevice/lavfi.c
+++ b/libavdevice/lavfi.c
@@ -156,9 +156,6 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
         av_bprint_init(&graph_file_pb, 0, AV_BPRINT_SIZE_UNLIMITED);
         ret = avio_read_to_bprint(avio, &graph_file_pb, INT_MAX);
         avio_closep(&avio);
-        av_bprint_chars(&graph_file_pb, '\0', 1);
-        if (!ret && !av_bprint_is_complete(&graph_file_pb))
-            ret = AVERROR(ENOMEM);
         if (ret) {
             av_bprint_finalize(&graph_file_pb, NULL);
             goto end;



More information about the ffmpeg-cvslog mailing list