[FFmpeg-cvslog] fftools/ffmpeg: Avoid creating unnecessary reference
Andreas Rheinhardt
git at videolan.org
Sun Dec 5 19:00:14 EET 2021
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Fri Dec 3 20:39:04 2021 +0100| [fc01a703dea4fe4f2eff73480958ee6c75aa8c30] | committer: Andreas Rheinhardt
fftools/ffmpeg: Avoid creating unnecessary reference
The only caller of do_video_out() doesn't need the frame afterwards,
ergo one can replace an av_frame_ref() by av_frame_move_ref().
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=fc01a703dea4fe4f2eff73480958ee6c75aa8c30
---
fftools/ffmpeg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index b0b32a69f2..855db934bf 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -1138,6 +1138,7 @@ static void do_subtitle_out(OutputFile *of,
}
}
+/* May modify/reset next_picture */
static void do_video_out(OutputFile *of,
OutputStream *ost,
AVFrame *next_picture)
@@ -1421,8 +1422,7 @@ static void do_video_out(OutputFile *of,
av_frame_unref(ost->last_frame);
if (next_picture)
- if (av_frame_ref(ost->last_frame, next_picture) < 0)
- goto error;
+ av_frame_move_ref(ost->last_frame, next_picture);
return;
error:
More information about the ffmpeg-cvslog
mailing list