[FFmpeg-cvslog] avfilter/vf_colormap: Avoid allocation of small array
Andreas Rheinhardt
git at videolan.org
Fri Apr 29 14:39:52 EEST 2022
ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Fri Apr 29 03:49:18 2022 +0200| [8449fbdf8e7669bfa05df594499dcf4e439561b3] | committer: Andreas Rheinhardt
avfilter/vf_colormap: Avoid allocation of small array
The number of elements is always two or three.
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8449fbdf8e7669bfa05df594499dcf4e439561b3
---
libavfilter/vf_colormap.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/libavfilter/vf_colormap.c b/libavfilter/vf_colormap.c
index d5c5bec39c..106333ced8 100644
--- a/libavfilter/vf_colormap.c
+++ b/libavfilter/vf_colormap.c
@@ -24,6 +24,7 @@
*/
#include "libavutil/attributes.h"
+#include "libavutil/avassert.h"
#include "libavutil/common.h"
#include "libavutil/opt.h"
#include "avfilter.h"
@@ -134,20 +135,15 @@ static void gauss_solve_triangular(const double *A, const int *p, double *b, int
static int gauss_solve(double *A, double *b, int n)
{
- int *p = av_calloc(n, sizeof(*p));
+ int p[3] = { 0 };
- if (!p)
- return 1;
+ av_assert2(n <= FF_ARRAY_ELEMS(p));
- if (!gauss_make_triangular(A, p, n)) {
- av_freep(&p);
+ if (!gauss_make_triangular(A, p, n))
return 1;
- }
gauss_solve_triangular(A, p, b, n);
- av_freep(&p);
-
return 0;
}
More information about the ffmpeg-cvslog
mailing list