[FFmpeg-cvslog] avcodec/sbrdsp_fixed: Fix integer overflows in sbr_qmf_deint_neg_c()
Michael Niedermayer
git at videolan.org
Fri Oct 21 23:51:04 EEST 2022
ffmpeg | branch: release/3.2 | Michael Niedermayer <michael at niedermayer.cc> | Mon May 2 00:51:12 2022 +0200| [cc77089393974438eab9a24a1e939a9fea2359f5] | committer: Michael Niedermayer
avcodec/sbrdsp_fixed: Fix integer overflows in sbr_qmf_deint_neg_c()
Fixes: signed integer overflow: 2147483645 + 16 cannot be represented in type 'int'
Fixes: 46993/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-4759025234870272
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 1537f40516d625fc5fa57db4fdfb737312fbc500)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=cc77089393974438eab9a24a1e939a9fea2359f5
---
libavcodec/sbrdsp_fixed.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c
index 840cc7a0b0..f3e8d974a4 100644
--- a/libavcodec/sbrdsp_fixed.c
+++ b/libavcodec/sbrdsp_fixed.c
@@ -100,8 +100,8 @@ static void sbr_qmf_deint_neg_c(int *v, const int *src)
{
int i;
for (i = 0; i < 32; i++) {
- v[ i] = ( src[63 - 2*i ] + 0x10) >> 5;
- v[63 - i] = (-src[63 - 2*i - 1] + 0x10) >> 5;
+ v[ i] = (int)(0x10U + src[63 - 2*i ]) >> 5;
+ v[63 - i] = (int)(0x10U - src[63 - 2*i - 1]) >> 5;
}
}
More information about the ffmpeg-cvslog
mailing list