[FFmpeg-cvslog] avfilter/vf_signature: Fix integer overflow in filter_frame()
Michael Niedermayer
git at videolan.org
Mon Sep 26 18:13:25 EEST 2022
ffmpeg | branch: release/4.3 | Michael Niedermayer <michael at niedermayer.cc> | Wed May 18 02:10:52 2022 +0200| [aec94df69bcbddfd17daf7d68bf6425cf73f9477] | committer: Michael Niedermayer
avfilter/vf_signature: Fix integer overflow in filter_frame()
Fixes: CID1403233
The second of the 2 changes may be unneeded but will help coverity
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit dd6040675ec18d19429f882caea6bb306ed6677a)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=aec94df69bcbddfd17daf7d68bf6425cf73f9477
---
libavfilter/vf_signature.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c
index bb4dc02e14..147eb66fc1 100644
--- a/libavfilter/vf_signature.c
+++ b/libavfilter/vf_signature.c
@@ -223,7 +223,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *picref)
dw1 = inlink->w / 32;
if (inlink->w % 32)
dw2 = dw1 + 1;
- denom = (sc->divide) ? dh1 * dh2 * dw1 * dw2 : 1;
+ denom = (sc->divide) ? dh1 * (int64_t)dh2 * dw1 * dw2 : 1;
for (i = 0; i < 32; i++) {
rowcount = 0;
@@ -249,7 +249,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *picref)
}
}
- denom = (sc->divide) ? 1 : dh1 * dh2 * dw1 * dw2;
+ denom = (sc->divide) ? 1 : dh1 * (int64_t)dh2 * dw1 * dw2;
for (i = 0; i < ELEMENT_COUNT; i++) {
const ElemCat* elemcat = elements[i];
More information about the ffmpeg-cvslog
mailing list