[FFmpeg-cvslog] avcodec/cbs_h266_syntax_template: Don't omit unused function parameter

Andreas Rheinhardt git at videolan.org
Mon Feb 26 02:06:39 EET 2024

ffmpeg | branch: release/6.1 | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Wed Feb 21 21:16:17 2024 +0100| [bebaad4371c6e75502607f177c5b8d5864b7ab81] | committer: James Almer

avcodec/cbs_h266_syntax_template: Don't omit unused function parameter

The calls to the sei_decoded_picture_hash read and write functions
are performed with four pointer arguments; just because one
of them is unused by the callees does not mean that they
can be omitted: This is undefined behaviour.
(This was not recognized because the SEI_MESSAGE_RW macro
contains casts.)

Reviewed-by: Mark Thompson <sw at jkqxz.net>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
(cherry picked from commit 484e7716bc9c79ead7b345e38197d414d5cdccc8)

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bebaad4371c6e75502607f177c5b8d5864b7ab81

 libavcodec/cbs_h266_syntax_template.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c
index 34c8ca6fe3..e8deb6bf13 100644
--- a/libavcodec/cbs_h266_syntax_template.c
+++ b/libavcodec/cbs_h266_syntax_template.c
@@ -3431,7 +3431,7 @@ static int FUNC(slice_header) (CodedBitstreamContext *ctx, RWContext *rw,
 static int FUNC(sei_decoded_picture_hash) (CodedBitstreamContext *ctx,
                                            RWContext *rw,
                                            H266RawSEIDecodedPictureHash *
-                                           current)
+                                           current, SEIMessageState *unused)
     int err, c_idx, i;

More information about the ffmpeg-cvslog mailing list