[FFmpeg-cvslog] qsv: Initialize impl_value
Michael Niedermayer
git at videolan.org
Tue May 28 04:50:51 EEST 2024
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sun May 26 23:34:05 2024 +0200| [c841cb45e81ebece26768c820c459b085668a37a] | committer: Michael Niedermayer
qsv: Initialize impl_value
Fixes: The warnings from CID1598553 Uninitialized scalar variable
Passing partly initialized structs is ugly and asking for hard to rieproduce bugs,
The uninitialized fields where not used
Reviewed-by: "Xiang, Haihao" <haihao.xiang-at-intel.com at ffmpeg.org>
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c841cb45e81ebece26768c820c459b085668a37a
---
libavcodec/qsv.c | 2 +-
libavutil/hwcontext_qsv.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c
index 6bbfe2a5a9..0c6fbd0dc0 100644
--- a/libavcodec/qsv.c
+++ b/libavcodec/qsv.c
@@ -496,7 +496,7 @@ static int qsv_new_mfx_loader(AVCodecContext *avctx,
mfxStatus sts;
mfxLoader loader = NULL;
mfxConfig cfg;
- mfxVariant impl_value;
+ mfxVariant impl_value = {0};
loader = MFXLoad();
if (!loader) {
diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c
index f3d919daea..7cec347478 100644
--- a/libavutil/hwcontext_qsv.c
+++ b/libavutil/hwcontext_qsv.c
@@ -839,7 +839,7 @@ static int qsv_d3d11_update_config(void *ctx, mfxHDL handle, mfxConfig cfg)
IDXGIDevice *pDXGIDevice = NULL;
HRESULT hr;
ID3D11Device *device = handle;
- mfxVariant impl_value;
+ mfxVariant impl_value = {0};
hr = ID3D11Device_QueryInterface(device, &IID_IDXGIDevice, (void**)&pDXGIDevice);
if (SUCCEEDED(hr)) {
@@ -913,7 +913,7 @@ static int qsv_d3d9_update_config(void *ctx, mfxHDL handle, mfxConfig cfg)
LUID luid;
D3DDEVICE_CREATION_PARAMETERS params;
HRESULT hr;
- mfxVariant impl_value;
+ mfxVariant impl_value = {0};
hr = IDirect3DDeviceManager9_OpenDeviceHandle(devmgr, &device_handle);
if (FAILED(hr)) {
@@ -995,7 +995,7 @@ static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg)
VADisplayAttribute attr = {
.type = VADisplayPCIID,
};
- mfxVariant impl_value;
+ mfxVariant impl_value = {0};
vas = vaGetDisplayAttributes(dpy, &attr, 1);
if (vas == VA_STATUS_SUCCESS && attr.flags != VA_DISPLAY_ATTRIB_NOT_SUPPORTED) {
@@ -1036,7 +1036,7 @@ static int qsv_new_mfx_loader(void *ctx,
mfxStatus sts;
mfxLoader loader = NULL;
mfxConfig cfg;
- mfxVariant impl_value;
+ mfxVariant impl_value = {0};
*ploader = NULL;
loader = MFXLoad();
More information about the ffmpeg-cvslog
mailing list