[Ffmpeg-devel] [PATCH] from DivX, Part 7: MSVC fixes

[Måns Rullgård]

Steve Lhomme <slhomme at divxcorp.com> writes:

> Rich Felker wrote:
>> On Fri, Dec 16, 2005 at 01:49:16PM -1000, Steve Lhomme wrote:
>>
>>> These are only the "soft" part of the MSVC fixes. That means I
>>> didn't include parts I know wouldn't make it, like the named fields
>>> in structures.
>>
>>>-    DCTELEM __align8 block[6][64];
>>>+    __align8(DCTELEM, block[6][64]);
>> And this is supposed to be readable how?? It doesn't even look like a
>> declaration anymore!
>
> Tell me in the standard C __align8 is defined. As ffmpeg is supposed
> to be compiled with any _standard_ C compiler.
> Same for the recently added  #warning I found in the code.

Look who's talking.  I spotted some #pragma pack in your patch.  Those
are both nonstandard and evil.

-- 
M?ns Rullg?rd
mru at inprovide.com