[Ffmpeg-devel] [PATCH] Build Darwin dynamic/shared libraries

[Michael Niedermayer]

Hi

On Wednesday 13 July 2005 14:06, Dan Villiom Podlaski Christiansen wrote:
[...]
> 3) initialise 3 common variables in libavcodec/msmpeg4.c, to not make
> ld(1) complain about common storage. I discussed this with a GCC hacker
> on IRC, and there was a reason why this was necessary, but I didn't
> quite understand what it was ;)

thats a bit unprecisse, is it needed by gcc? a specific version? the c 
standard? is it a warning or an error?
if its needed by the c standard its ok obviously, if its not and just a 
warning its rejected, ...


> 4) make the vhooks Mach-O bundles rather than libraries.
> 5) add support for a ${DESTDIR} environment variable to force
> installation into another path than the root. I found it quite useful.

we have bindir, libdir, mandir and prefix isnt that enough?

[...]

iam also not too happy about all the ifeq ($(CONFIG_DARWIN),) in the 
makefiles, this should be in configure IMHO

> @@ -5,6 +5,7 @@
>  #
>  #set -x
>  # Even in the 21st century some diffs are not supporting -u.
> +
>  diff -u "$0" "$0" > /dev/null 2>&1
>  if [ $? -eq 0 ]; then
>    diff_cmd="diff -u"

cosmetical change

[...]

-- 
Michael