[Ffmpeg-devel] [PATCH] Build Darwin dynamic/shared libraries

Michael Niedermayer michaelni
Sat Jul 16 14:14:05 CEST 2005


On Saturday 16 July 2005 12:27, Dan Villiom Podlaski Christiansen wrote:
> >> +ifeq ($(CONFIG_DARWIN),)
> >> +else
> >> +endif
> >
> > [...]
> >
> >> +ifeq ($(CONFIG_DARWIN),)
> >> +SHFLAGS+=-Wl,-soname,$(SLIB).$(SPPMAJOR)
> >> +endif
> >
> > CONFIG_DARWIN checks which shouldnt be in a Makefile
> Very well, I'll put these into configure. Is it OK to extend the
> libpostproc naming convention with the version in filename and soname to
> libav* as well? 

no, the whole thing is a mess, if you want to fix it thats fine but if not 
then leave it the way it is using the first value of the ffmpeg version 
number alone as soname-version in all libs is just wrong
binary compatibility is broken often but noone dared to increase the 0. value, 
not to mention that it wouldnt work with cvs versions
the correct solution seems to me to have a ABI version for each lib ...

> This would simplify things. I'd like to point out that 
> unfortunately, I don't have a Linux box to test on, so I can't verify
> that the Linux side works.
> >> -all:    $(SWSLIB) $(PPLIB) $(SPPLIB)
> >> +all:    $(SWSLIB) $(LIB) $(SLIB)
> >
> > variable renaming
> Yes. This was to have the line 'SHFLAGS="$SHFLAGS -install_name
> ${libdir#$install_prefix}/\$(SLIB) -compatibility_version
> \$(SLIB_VERSION) -current_version \$(SLIB_VERSION)"' in configure affect
> libpostproc as well. The more I move to configure, the more I need to
> ensure that the same variable names are used everywhere.

then its ok, i just thought you renamed it for fun :)

> Anyway, do you want --install-prefix, $DESTROOT, or perhaps both?

if i understand that correctly than $DESTDIR would be the default value for 
install_prefix, that would be ok


More information about the ffmpeg-devel mailing list