[Ffmpeg-devel] [PATCH] bounds check in h264.c

Reimar Döffinger Reimar.Doeffinger
Thu Jul 21 20:43:00 CEST 2005


Hi,
I think there is a +1 mssing in the if statement in line 3111, at least valgrind
complained about it in one case.

Greetings,
Reimar D?ffinger
-------------- next part --------------
Index: libavcodec/h264.c
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/h264.c,v
retrieving revision 1.145
diff -u -r1.145 h264.c
--- libavcodec/h264.c	14 Jul 2005 21:57:22 -0000	1.145
+++ libavcodec/h264.c	21 Jul 2005 16:35:57 -0000
@@ -3108,7 +3108,7 @@
     if(deblock_top){
         XCHG(*(uint64_t*)(h->top_borders[0][s->mb_x]+0), *(uint64_t*)(src_y +1), temp64, xchg);
         XCHG(*(uint64_t*)(h->top_borders[0][s->mb_x]+8), *(uint64_t*)(src_y +9), temp64, 1);
-        if(s->mb_x < s->mb_width){
+        if(s->mb_x+1 < s->mb_width){
             XCHG(*(uint64_t*)(h->top_borders[0][s->mb_x+1]), *(uint64_t*)(src_y +17), temp64, 1);
         }
     }



More information about the ffmpeg-devel mailing list