[Ffmpeg-devel] Re: [PATCH] RTP/RTSP and MPEG4-AAC audio (Repost)

[Romain DEGEZ]

Michael Niedermayer wrote:

>>Are these patches rejected or maybe noone had time to look at them ?
> 
> 
> iam not finished with looking through them, but heres a preliminary list of 
> things i didnt like

Hello Michael, (and the list :-)

I corrected some of these issues but I want to know if there is a chance for 
this patch to be applied ?
It seem that I am almost the only one interested in the rtp/rtsp support of 
libavformat ;-)

> cosmetical changes

Yeah but as I am almost the only one using this (old) code, is it a big issue ?
Are these cosmetical changes nonsense ?

>>-#ifdef DEBUG
>>-    printf("Sending:\n%s--\n", buf);
>>-#endif
>>+    av_log(s, AV_LOG_DEBUG, " Sending:\n%s--\n", buf);
> 
> 
> the av_log should stay behind some #ifdef 

Mhh... is the 'AV_LOG_DEBUG' log level not sufficient ? I thought the av_log API 
was a way to avoid the use of such #ifdef.

>>+enum RTPAttrEnum
>>+{
>>+    SIZE_LENGTH,
>>+    INDEX_LENGTH,
>>+    INDEX_DELTA_LENGTH,
>>+    PROFILE_LEVEL_ID,
>>+    STREAM_TYPE,
>>+    MODE,
>>+    OBJECT_TYPE,
>>+    END_OF_ENUM
>>+};
> 
> 
> these need some prefix to avoid possible name clashes

You are right, corrected.

Patches are attached. (not base64 encoded this time ;-)

I'm ok to correct anything if you consider applying this patch :-)

I would love increase the rtp/rtsp client and server support in ffmpeg but are 
you interested in?

Tanks you in advance!

-- 
Romain DEGEZ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtp.c.patch
Type: text/x-patch
Size: 23288 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20050506/a07fb578/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtp.h.patch
Type: text/x-patch
Size: 35988 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20050506/a07fb578/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp.c.patch
Type: text/x-patch
Size: 72467 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20050506/a07fb578/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp.h.patch
Type: text/x-patch
Size: 36981 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20050506/a07fb578/attachment-0003.bin>