[Ffmpeg-devel] build broken again...

[Jacob Meuser]

On Mon, May 09, 2005 at 12:21:18PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Monday 09 May 2005 11:32, Jacob Meuser wrote:
> > On Sun, May 08, 2005 at 12:35:09PM -0400, Rich Felker wrote:
> > > On Sun, May 08, 2005 at 06:08:08PM +0200, Fran?ois Revol wrote:
> > > > OPTFLAGS=-O3 -Wall -Wno-switch -DPIC -fomit-frame-pointer
> > > >
> > > > (with PIC of course)
> > >
> > > PIC does not work, afaik. Stop insisting on using it.
> >
> > PIC does work, and it is needed some places (ok, not if you don't
> > use shared libraries, but that is another discussion/flame war).
> >
> > libavcodec/i386/dsputil_mmx.c has some code that depends on PIC
> > being defined ~ line 63 (assuming shared libraries), but the
> > configure option --enable-shared doesn't add -DPIC to CFLAGS.
> >
> > therefore I suggest the attached patch, so that PIC works, without
> > having to add -DPIC manually, with the result that people think it
> > doesn't work, etc.
> 
> applied

thanks ;)

-- 
<jakemsr at jakemsr.com>