[Ffmpeg-devel] [PATCH] remove obsolete cygwin_inttypes.h

[Diego Biurrun]

Hi!

Cygwin has had inttypes.h since version 1.5 which was released two years
ago.  FFmpeg does not currently compile under Cygwin but using
cygwin_inttypes.h just makes it worse, the inttypes check in configure fails
and compilation immediately fails with the error message below.

I propose removing cygwin_inttypes.h, it has long outlived its usefulness.
The attached patch would remove a check from the Cygwin section in
configure, cvs removing the file would also be necessary.

I don't think that file has any value for backwards compatibility.
Obviously Ffmpeg has evolved far too much to still work with that clutch and
if somebody decides to fix the port, it should be done properly with the
native inttypes.h.

Diego

diego at ANTARES ~/mplayer/ffmpeg
$ make
make -C libavcodec all
make[1]: Entering directory `/home/diego/mplayer/ffmpeg/libavcodec'
gcc -O3 -g -Wall -Wno-switch  -DHAVE_AV_CONFIG_H -I.. -D_FILE_OFFSET_BITS=64
-D_
LARGEFILE_SOURCE -D_GNU_SOURCE  -c -o bitstream.o bitstream.c
In file included from avcodec.h:14,
                 from bitstream.c:28:
common.h:91: warning: redefinition of `int8_t'
/usr/include/stdint.h:18: warning: `int8_t' previously declared here
common.h:92: warning: redefinition of `int16_t'
/usr/include/stdint.h:19: warning: `int16_t' previously declared here
common.h:93: error: conflicting types for `int32_t'
/usr/include/stdint.h:20: error: previous declaration of `int32_t'
common.h:94: warning: redefinition of `uint8_t'
/usr/include/stdint.h:24: warning: `uint8_t' previously declared here
common.h:95: warning: redefinition of `uint16_t'
/usr/include/stdint.h:25: warning: `uint16_t' previously declared here
common.h:96: error: conflicting types for `uint32_t'
/usr/include/stdint.h:28: error: previous declaration of `uint32_t'
common.h:102: warning: redefinition of `int64_t'
/usr/include/stdint.h:21: warning: `int64_t' previously declared here
common.h:103: warning: redefinition of `uint64_t'
/usr/include/stdint.h:30: warning: `uint64_t' previously declared here
common.h:129: warning: redefinition of `int_fast8_t'
/usr/include/stdint.h:46: warning: `int_fast8_t' previously declared here
common.h:130: error: conflicting types for `int_fast16_t'
/usr/include/stdint.h:47: error: previous declaration of `int_fast16_t'
common.h:131: error: conflicting types for `int_fast32_t'
/usr/include/stdint.h:48: error: previous declaration of `int_fast32_t'
common.h:132: warning: redefinition of `uint_fast8_t'
/usr/include/stdint.h:51: warning: `uint_fast8_t' previously declared here
common.h:133: error: conflicting types for `uint_fast16_t'
/usr/include/stdint.h:52: error: previous declaration of `uint_fast16_t'
common.h:134: error: conflicting types for `uint_fast32_t'
/usr/include/stdint.h:53: error: previous declaration of `uint_fast32_t'
make[1]: *** [bitstream.o] Error 1
make[1]: Leaving directory `/home/diego/mplayer/ffmpeg/libavcodec'
make: *** [lib] Error 2
-------------- next part --------------
Index: configure
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/configure,v
retrieving revision 1.180
diff -u -r1.180 configure
--- configure	13 May 2005 20:57:27 -0000	1.180
+++ configure	16 May 2005 15:12:05 -0000
@@ -314,10 +314,6 @@
 extralibs=""
 cygwin="yes"
 EXESUF=".exe"
-test -f /usr/include/inttypes.h || \
-test -f /usr/local/include/inttypes.h || \
-echo "Missing inttypes.h, please copy cygwin_inttypes.h to" \
-     "/usr/local/include/inttypes.h !!!"
 ;;
 Linux)
 LDFLAGS="$LDFLAGS -rdynamic"