[Ffmpeg-devel] Re: [Ffmpeg-devel-old] [PATCH] Limit number of processed sample with pcm codecs and a libgsm warper

Alban Bedel albeu
Mon May 23 11:03:44 CEST 2005


On Mon, 23 May 2005 01:39:52 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Thursday 19 May 2005 01:44, Alban Bedel wrote:
> > Hi all,
> >
> > i'm hacking a little voip prog that use lavc. However i run into a small
> > problem with the pcm formats and g726. The encoder encode as much data
> > as there is space in the output buffer. One can hack a bit with pcm
> > and alaw,ulaw. But then with g726 that's start to be messy.
> >
> > The patch add a max_samples field to the avctx, if non 0 the pcm and g726
> > encoder and decoder will only process at most that many samples in a run.
> 
> i agree that some max sample limit is needed but iam not sure if 
> AVCodecContext is the right place for it

I thought the same, but i first wanted a quick fix that would not break
the api.

It would be better to simply to pass that limiter directly to the enc/dec.
It's not possible to change the function arguments as they are shared
with video. So the only solution i see as left is to pass some struct
(AVFrame ?) to the enc/dec instead of the raw samples array.

However that mean changing every audio enc/dec and might requiere breaking
the API compatibility (or putting wrapers, etc but you probably don't want
that).

> >
> > Then i'm needing gsm, so i made a little warper to libgsm. Dunno if a
> > "native lavc" gsm enc/decoder is planned but for now that fill the gap.
> > I also attached a patch for ffmpeg configure.
> 
> applied

Nice :)

	Albeu



-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click
_______________________________________________
Ffmpeg-devel mailing list
Ffmpeg-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ffmpeg-devel





More information about the ffmpeg-devel mailing list